packages/zip-it-and-ship-it/src/runtimes/node/in_source_config/index.ts (1)

125-126: Use an own-property check for handler matching.

On Lines 125-126, name in eventHandlers can match prototype properties. Prefer an own-key check to avoid false positives in subscription extraction.

Proposed change

-    if (name && name in eventHandlers) {
+    if (name && Object.prototype.hasOwnProperty.call(eventHandlers, name)) {
       events.push(eventHandlers[name as keyof typeof eventHandlers])
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@packages/zip-it-and-ship-it/src/runtimes/node/in_source_config/index.ts`
around lines 125 - 126, The current check uses "name in eventHandlers" which can
match prototype properties; change it to an own-property check when deciding to
push handlers: verify the key exists on eventHandlers itself (e.g., use
Object.prototype.hasOwnProperty.call(eventHandlers, name) or equivalent) before
calling events.push(eventHandlers[name as keyof typeof eventHandlers]) so only
own keys are matched.

packages/zip-it-and-ship-it/tests/unit/runtimes/node/in_source_config.test.ts (1)

827-892: LGTM! Comprehensive test coverage for event subscriptions extraction.

The tests cover the key scenarios well:

• Object literal and binding-resolved default exports
• CJS exports.default pattern
• export { x as default } re-export syntax
• Negative case for function exports
• Filtering of unknown property names

The user* → identity_* slug mapping (e.g., userLogin → identity_login) aligns with Netlify Identity events.

Consider adding a test for when all properties are unrecognized to verify eventSubscriptions remains undefined:

💡 Optional: Add edge case test

test('Does not set eventSubscriptions when all properties are unknown', () => {
  const source = `export default { helperOne() {}, helperTwo() {} }`

  const isc = parseSource(source, options)

  expect(isc.eventSubscriptions).toBeUndefined()
  expect(isc.runtimeAPIVersion).toBe(2)
})

,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@packages/zip-it-and-ship-it/tests/unit/runtimes/node/in_source_config.test.ts`
around lines 827 - 892, Add an edge-case unit test in the same "Event
subscriptions" describe block that verifies parseSource (used as
parseSource(source, options)) does not set eventSubscriptions when the
default-exported object only contains unknown helper methods; create a test
named like "Does not set eventSubscriptions when all properties are unknown",
use a source such as `export default { helperOne() {}, helperTwo() {} }`, call
const isc = parseSource(source, options) and assert isc.eventSubscriptions is
undefined and isc.runtimeAPIVersion is 2.