refactor: adjust code to already comply with upcoming ESLint v9#996
Merged
refactor: adjust code to already comply with upcoming ESLint v9#996
Conversation
ShGKme
reviewed
Jun 4, 2025
lib/index.ts
Outdated
Comment on lines
1
to
8
| import type { NextcloudEvents } from './Event.ts' | ||
| /** | ||
| * SPDX-FileCopyrightText: 2019 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: GPL-3.0-or-later | ||
| */ | ||
| import type { EventBus } from './EventBus' | ||
| import type { EventHandler } from './EventHandler' | ||
| import type { NextcloudEvents } from './Event' | ||
| import type { EventBus } from './EventBus.ts' | ||
| import type { EventHandler } from './EventHandler.ts' |
Contributor
There was a problem hiding this comment.
Could you fix the comment position here?
Contributor
Author
There was a problem hiding this comment.
Damn fixed another on and thought I catched all...
ShGKme
reviewed
Jun 4, 2025
Contributor
|
Why not add ESLint config? |
Contributor
Author
Still some bugs found for which I will create a PR |
Signed-off-by: Ferdinand Thiessen <[email protected]>
4d7355f to
ca50d0d
Compare
ShGKme
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.