NcSelect: make same height and color as NcTextField#5829
Conversation
|
Known issue we decided to procrastinate, on Firefox it looks like this:
(there are no |
marcoambrosini
left a comment
There was a problem hiding this comment.
Hi @GVodyanov, the height of these elements needs to be --default-clickable-area, the input fields will also shrink a bit soon
That's what it already should be set to actually @marcoambrosini |
susnux
left a comment
There was a problem hiding this comment.
The color changes should only be applied to the placeholder, not the input element as the input text must stay main text color.
|
I made the height of everything |
3f659f2 to
c7d879e
Compare
Signed-off-by: Grigory V <[email protected]>
c7d879e to
02a20a4
Compare
|
Please remember to add correct labels:
Also always remember to backport to next (there is a TODO section in the PR template for this :) ). |
|
/backport to next |
| .vs__selected-options { | ||
| // If search is hidden, ensure that the height of the search is the same | ||
| min-height: 40px; // 36px search height + 4px search margin | ||
| min-height: var(--default-clickable-area); |
There was a problem hiding this comment.
Selector specificity either isn't big enough or scoped enough here (see leaked styles from server and viewer):
Not a part of this PR, of course, but something to consider
☑️ Resolves
🖼️ Screenshots