fix(NcAppSettingsDialog): Adjust navigation entries to match Nextcloud 30 design#5963
Merged
fix(NcAppSettingsDialog): Adjust navigation entries to match Nextcloud 30 design#5963
Conversation
…d 30 design Signed-off-by: Ferdinand Thiessen <[email protected]>
Contributor
Author
|
/backport to next |
28 tasks
ShGKme
approved these changes
Aug 15, 2024
Contributor
ShGKme
left a comment
There was a problem hiding this comment.
It feels like paddings in navigation are too huge in comparison with other containers and dialogs. Maybe decrease it to 2*base?
Contributor
Author
|
I already reduced them a bit, can we do the rest in a follow up? Because shrinking it further that needs special handling for 29 and 28. |
marcoambrosini
approved these changes
Aug 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Ensure correct border radius and padding is used.
🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade