fix(NcActions): Pressing escape should always close the actions#6037
Merged
fix(NcActions): Pressing escape should always close the actions#6037
Conversation
Contributor
Author
|
/backport to next |
ShGKme
approved these changes
Sep 2, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
1. Opening actions, then e.g. right-click for context menu. 2. Now press escape -> context menu closes 3. Press escape again -> nothing happens 4. (with this commit): Pressing it a second time will close the actions as expected Signed-off-by: Ferdinand Thiessen <[email protected]>
48ffbfd to
1f2a788
Compare
raimund-schluessler
approved these changes
Sep 2, 2024
Antreesy
approved these changes
Sep 2, 2024
This was referenced Sep 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
nextrequested with a Vue 3 upgrade