Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix how we handle log tailing when the line is nil #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

Fix how we handle log tailing when the line is nil #1283

merged 1 commit into from
Sep 19, 2025

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Sep 18, 2025

Proposed changes

Fix how we handle log tailing when the line is nil.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley self-assigned this Sep 18, 2025
@dhurley dhurley requested a review from a team as a code owner September 18, 2025 15:31
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Sep 18, 2025
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Sep 18, 2025
@dhurley dhurley changed the base branch from main to release-3.3.2 September 18, 2025 15:31
@dhurley dhurley merged commit 60046f8 into release-3.3.2 Sep 19, 2025
63 of 66 checks passed
@dhurley dhurley deleted the fix-log-tailers branch September 19, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@dhurley dhurley

Labels

bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dhurley @craigell @sean-breen @aphralG