feat: adds testRunner config to specify using node:test #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2e33478 to
5940489
Compare
wraithgar
reviewed
Oct 16, 2025
| // Verify test scripts are for node:test | ||
| t.equal(pkg.scripts.test, 'node --test --test-timeout=3000') | ||
| t.equal( | ||
| pkg.scripts['test:cover'], |
Member
There was a problem hiding this comment.
so we don't run coverage on npm test but on npm test:cover? When does CI enforce this?
Contributor
Author
There was a problem hiding this comment.
@wraithgar Yep! This makes it easier to separate it from the others. When it is v24+ of node, it'll run test:cover and get an exit code 1, indicating a failure on the tests.
wraithgar
approved these changes
Oct 16, 2025
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Oct 16, 2025
🤖 I have created a release *beep* *boop* --- ## [4.26.0](v4.25.1...v4.26.0) (2025-10-16) ### Features * [`f3f2f25`](f3f2f25) [#529](#529) adds testRunner config to specify using node:test (@owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for using the built-in
node:testtest runner as an alternative totap, allowing projects to opt in via configuration. It updates configuration logic, generated files, and CI workflows to handle both test runners appropriately, and includes new tests to verify the correct behavior for each scenario.I validated that there is no change from applying template-oss unless the package has updated the testRunner to be
node:test