fix(js): recognize NodeNext as ESM #31508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
I wonder if there is, or if there needs to be, a further check to verify that the adjacent package.json contains |
Contributor
|
@Coly010 let's remove me as the reviewer 😅 hehe I have enough |
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
Contributor
|
View your CI Pipeline Execution ↗ for commit f837e83
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Dec 11, 2025
This was referenced Dec 11, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior NodeNext is not recognized as ESM. This causes this warning message to be logged, even when you have `"type": "module",` in the `package.json` file and are compile TypeScript to `"module": "NodeNext"`. ``` Package type is set to "module" but "cjs" format is included. Going to use "esm" format instead. You can change the package type to "commonjs" or remove type in the package.json file. ``` ## Expected Behavior Don't log this message. It is incorrect. --------- Co-authored-by: Colum Ferry <[email protected]>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
NodeNext is not recognized as ESM. This causes this warning message to be logged, even when you have
"type": "module",in thepackage.jsonfile and are compile TypeScript to"module": "NodeNext".Expected Behavior
Don't log this message. It is incorrect.