-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix(linter): base eslint config should ignore out-tsc directories #33639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 02a518b
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a flaky task in your failed CI:
🔂 Since the failure was identified as flaky, we reran your CI automatically.
🎓 Learn more about Self-Healing CI on nx.dev
Co-authored-by: Coly010 <[email protected]>
Co-authored-by: Coly010 <[email protected]> [Self-Healing CI Rerun]
Co-authored-by: Coly010 <[email protected]> [Self-Healing CI Rerun]
c9c6274 to
02a518b
Compare
…3639) ## Current Behavior The base `eslint` config will ignore `**/dist` but not `**/out-tsc`. This can cause issues if lint is run after a `typecheck` which has placed `.d.ts` files into an `out-tsc` directory. ## Expected Behavior Base eslint config should ignore `**/out-tsc` --------- Co-authored-by: nx-cloud[bot] <71083854+nx-cloud[bot]@users.noreply.github.com> Co-authored-by: Coly010 <[email protected]> (cherry picked from commit f87e20f)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
The base
eslintconfig will ignore**/distbut not**/out-tsc.This can cause issues if lint is run after a
typecheckwhich has placed.d.tsfiles into anout-tscdirectory.Expected Behavior
Base eslint config should ignore
**/out-tsc