Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(angular-rspack): use CJS when serving applications for HMR #33106 #33693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Coly010 merged 1 commit into from
Dec 3, 2025
Merged

fix(angular-rspack): use CJS when serving applications for HMR #33106 #33693

Coly010 merged 1 commit into from
Dec 3, 2025

Conversation

@Coly010
Copy link
Contributor

@Coly010 Coly010 commented Dec 3, 2025

Current Behavior

Angular Rspack outputs ESM for build and serve. However, with serve, it causes issue for HMR.

Expected Behavior

Use CJS for serve to allow HMR to work correctly

Related Issue(s)

Fixes #33106

@Coly010 Coly010 requested a review from a team as a code owner December 3, 2025 12:55
@Coly010 Coly010 requested a review from leosvelperez December 3, 2025 12:55
@Coly010 Coly010 self-assigned this Dec 3, 2025
@vercel
Copy link

vercel bot commented Dec 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nx-dev Ready Ready Preview Dec 3, 2025 1:02pm

@netlify
Copy link

netlify bot commented Dec 3, 2025 •
edited
Loading

✅ Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit b577bee
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/693033412eb2130008264d96
😎 Deploy Preview https://deploy-preview-33693--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b577bee

Command Status Duration Result
nx affected --targets=lint,test,test-kt,build,e... ✅ Succeeded 3m 51s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 2m 30s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-12-03 13:02:44 UTC

@Coly010 Coly010 merged commit b740baf into master Dec 3, 2025
20 checks passed
@Coly010 Coly010 deleted the angular-rspack/hmr-for-esm branch December 3, 2025 13:31
barbados-clemens pushed a commit that referenced this pull request Dec 8, 2025
@Coly010 @barbados-clemens
fix(angular-rspack): use CJS when serving applications for HMR #33106 (…
9d75151 
…#33693)

## Current Behavior
Angular Rspack outputs ESM for build and serve. However, with serve, it
causes issue for HMR.

## Expected Behavior
Use CJS for serve to allow HMR to work correctly

## Related Issue(s)

Fixes #33106
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

Assignees

@Coly010 Coly010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@rspack/[email protected] not reflecting code changes after recompilation

3 participants

@Coly010 @leosvelperez