fix(js): resolve nx binary from workspace root in node executor #33842
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit 25a24d0
☁️ Nx Cloud last updated this comment at |
When running `nx serve` with a NestJS project (and other node apps using
`runBuildTargetDependencies`), the node executor attempts to resolve the `nx`
binary using `require.resolve('nx')`. This fails with pnpm because:
1. `nx` is only a `devDependency` of `@nx/js`, not a regular `dependency`
2. pnpm's strict isolation prevents packages from resolving dependencies not
declared in their package.json
3. The `nx` package doesn't have a `main` field, only `bin`, so
`require.resolve('nx')` fails
This results in `Error: Cannot find module 'nx'` when trying to serve a
NestJS application.
The node executor should correctly resolve and use the `nx` binary from the
workspace where it's always installed.
Fixes #33776
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Coly010
approved these changes
Dec 12, 2025
4 tasks
This was referenced Dec 15, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
## Current Behavior
When running `nx serve` with a NestJS project (and other node apps using
`runBuildTargetDependencies`), the node executor attempts to resolve the
`nx` binary using `require.resolve('nx')`. This fails with because
`nx/package.json` does no longer has a `main` field.
## Expected Behavior
The node executor should correctly resolve and use the `nx` binary from
the workspace where it's always installed.
This is fixed by using `nx/bin/nx.js` instead of just `nx` -- as we do
in other places.
## Related Issue(s)
Fixes #33776
Co-authored-by: Claude Opus 4.5 <[email protected]>
(cherry picked from commit 192099a)
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
## Current Behavior
When running `nx serve` with a NestJS project (and other node apps using
`runBuildTargetDependencies`), the node executor attempts to resolve the
`nx` binary using `require.resolve('nx')`. This fails with because
`nx/package.json` does no longer has a `main` field.
## Expected Behavior
The node executor should correctly resolve and use the `nx` binary from
the workspace where it's always installed.
This is fixed by using `nx/bin/nx.js` instead of just `nx` -- as we do
in other places.
## Related Issue(s)
Fixes #33776
Co-authored-by: Claude Opus 4.5 <[email protected]>
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running
nx servewith a NestJS project (and other node apps usingrunBuildTargetDependencies), the node executor attempts to resolve thenxbinary usingrequire.resolve('nx'). This fails with becausenx/package.jsondoes no longer has amainfield.Expected Behavior
The node executor should correctly resolve and use the
nxbinary from the workspace where it's always installed.This is fixed by using
nx/bin/nx.jsinstead of justnx-- as we do in other places.Related Issue(s)
Fixes #33776