fix(module-federation): check port availability before starting remote proxies #33871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
View your CI Pipeline Execution ↗ for commit a11f8fd
☁️ Nx Cloud last updated this comment at |
…e proxies When multiple MF dev servers run concurrently and share the same remote, they would both attempt to start proxies on the same port, causing EADDRINUSE errors. This fix checks if a port is already in use before attempting to start a proxy. If the port is occupied (likely by another MF dev server that started earlier), the proxy is skipped for that remote since it's already being served. Uses the existing `waitForPortOpen` utility with retries: 0 to perform an immediate check. Fixes #33470
74b1ce8 to
a11f8fd
Compare
jaysoo
approved these changes
Dec 15, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
…e proxies (#33871) When multiple MF dev servers run concurrently and share the same remote, they would both attempt to start proxies on the same port, causing EADDRINUSE errors. This fix checks if a port is already in use before attempting to start a proxy. If the port is occupied (likely by another MF dev server that started earlier), the proxy is skipped for that remote since it's already being served. Uses the existing `waitForPortOpen` utility with retries: 0 to perform an immediate check. Fixes #33470 (cherry picked from commit 68d539c)
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
…e proxies (#33871) When multiple MF dev servers run concurrently and share the same remote, they would both attempt to start proxies on the same port, causing EADDRINUSE errors. This fix checks if a port is already in use before attempting to start a proxy. If the port is occupied (likely by another MF dev server that started earlier), the proxy is skipped for that remote since it's already being served. Uses the existing `waitForPortOpen` utility with retries: 0 to perform an immediate check. Fixes #33470 (cherry picked from commit 68d539c)
FrozenPandaz
pushed a commit
that referenced
this pull request
Dec 15, 2025
…e proxies (#33871) When multiple MF dev servers run concurrently and share the same remote, they would both attempt to start proxies on the same port, causing EADDRINUSE errors. This fix checks if a port is already in use before attempting to start a proxy. If the port is occupied (likely by another MF dev server that started earlier), the proxy is skipped for that remote since it's already being served. Uses the existing `waitForPortOpen` utility with retries: 0 to perform an immediate check. Fixes #33470
4 tasks
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple MF dev servers run concurrently and share the same remote,
they would both attempt to start proxies on the same port, causing
EADDRINUSE errors.
This fix checks if a port is already in use before attempting to start
a proxy. If the port is occupied (likely by another MF dev server that
started earlier), the proxy is skipped for that remote since it's
already being served.
Uses the existing
waitForPortOpenutility with retries: 0 to performan immediate check.
Fixes #33470