-
Notifications
You must be signed in to change notification settings - Fork 104
feat(build,dev): add vite and vue version to banner #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundle Stats β nuxt-cli size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats β create-nuxt size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats β nuxi size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
commit: |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
=======================================
Coverage ? 27.37%
=======================================
Files ? 78
Lines ? 4070
Branches ? 230
=======================================
Hits ? 1114
Misses ? 2925
Partials ? 31 β View full report in Codecov by Sentry. π New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1021 will not alter performanceComparing Summary
|
| const kit = await loadKit(cwd) | ||
| const config = await kit.loadNuxtConfig({ cwd }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will likely slow down the load of nuxt by (probably) ~100ms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielroe The function won't be awaited. See #1021 (comment)
This shouldn't slow down the dev server then, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielroe is there any other way to get current builder without using the kit?
danielroe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! β€οΈ
π Linked issue
Resolves #1022
β Type of change
π Description
Add version of nuxt builder (
vite,rolldown-vite,rspackandwebpack) andvueto the cli banner.viterolldown-viterspackwebpack