fix(nuxt): allow object-format href in <NuxtLink>

danielroe · danielroe · commit c69e4c30d2b0 · 2025-10-07T20:07:55.000+01:00
diff --git a/packages/nuxt/src/app/components/nuxt-link.ts b/packages/nuxt/src/app/components/nuxt-link.ts
@@ -422,7 +422,7 @@ export function defineNuxtLink (options: NuxtLinkOptions) {
 
       return () => {
         if (!isExternal.value && !hasTarget.value && !isHashLinkWithoutHashMode(to.value)) {
-          const routerLinkProps: RouterLinkProps & VNodeProps & AllowedComponentProps & AnchorHTMLAttributes = {
+          const routerLinkProps: RouterLinkProps & VNodeProps & AllowedComponentProps & Omit<AnchorHTMLAttributes, 'href'> = {
             ref: elRef,
             to: to.value,
             activeClass: props.activeClass || options.activeClass,
@@ -527,7 +527,7 @@ export function defineNuxtLink (options: NuxtLinkOptions) {
     },
     // }) as unknown as DefineComponent<NuxtLinkProps, object, object, ComputedOptions, MethodOptions, object, object, EmitsOptions, string, object, NuxtLinkProps, object, SlotsType<NuxtLinkSlots>>
   }) as unknown as (new<CustomProp extends boolean = false>(props: NuxtLinkProps<CustomProp> & VNodeProps & AllowedComponentProps & AnchorHTMLAttributes) => InstanceType<DefineSetupFnComponent<
-    NuxtLinkProps<CustomProp> & VNodeProps & AllowedComponentProps & AnchorHTMLAttributes,
+    NuxtLinkProps<CustomProp> & VNodeProps & AllowedComponentProps & Omit<AnchorHTMLAttributes, 'href'>,
     [],
     SlotsType<NuxtLinkSlots<CustomProp>>
   >>) & Record<string, any>
diff --git a/test/fixtures/basic-types/app/app-types.ts b/test/fixtures/basic-types/app/app-types.ts
@@ -263,11 +263,17 @@ describe('typed router integration', () => {
   it('allows typing NuxtLink', () => {
     // @ts-expect-error this named route does not exist
     h(NuxtLink, { to: { name: 'some-thing' } })
+    // @ts-expect-error this named route does not exist
+    h(NuxtLink, { href: { name: 'some-thing' } })
     // this one does
     h(NuxtLink, { to: { name: 'page' } })
+    h(NuxtLink, { href: { name: 'page' } })
     // @ts-expect-error this is an invalid param
     h(NuxtLink, { to: { name: 'param-id', params: { bob: 23 } } })
+    // @ts-expect-error this is an invalid param
+    h(NuxtLink, { href: { name: 'param-id', params: { bob: 23 } } })
     h(NuxtLink, { to: { name: 'param-id', params: { id: 4 } } })
+    h(NuxtLink, { href: { name: 'param-id', params: { id: 4 } } })
 
     // doesn't throw an error when accessing properties of component
     const _props = NuxtLink.props
