Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Exponential back-off for process restarting #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gustavohenke merged 2 commits into from
Jan 12, 2024
Merged

Exponential back-off for process restarting #462

gustavohenke merged 2 commits into from
Jan 12, 2024

Conversation

@gustavohenke
Copy link
Member

@gustavohenke gustavohenke commented Jan 12, 2024

Title.

$ conc --restart-tries 4 --restart-after exponential "date && exit 1"
[0] Fri 12 Jan 2024 14:10:56 -03
[0] date && exit 1 exited with code 1
[0] date && exit 1 restarted
[0] Fri 12 Jan 2024 14:10:57 -03
[0] date && exit 1 exited with code 1
[0] date && exit 1 restarted
[0] Fri 12 Jan 2024 14:10:59 -03
[0] date && exit 1 exited with code 1
[0] date && exit 1 restarted
[0] Fri 12 Jan 2024 14:11:03 -03
[0] date && exit 1 exited with code 1
[0] date && exit 1 restarted
[0] Fri 12 Jan 2024 14:11:11 -03
[0] date && exit 1 exited with code 1

Closes #265

@gustavohenke gustavohenke requested a review from paescuj January 12, 2024 17:16
@gustavohenke gustavohenke added this to the v9 milestone Jan 12, 2024
@coveralls
Copy link

coveralls commented Jan 12, 2024 •
edited
Loading

Coverage Status

coverage: 99.322% (+0.006%) from 99.316%
when pulling 597a1f8 on exponential-backoff
into aedebc1 on main.

gustavohenke
gustavohenke commented Jan 12, 2024
View reviewed changes
src/flow-control/restart-process.spec.ts
Comment on lines +15 to +18

// Don't use TestScheduler as it's hardcoded to a max number of "frames" (time),
// which don't work for some tests in this suite
scheduler = new VirtualTimeScheduler();
Copy link
Member Author

@gustavohenke gustavohenke Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evidence https://github.com/ReactiveX/rxjs/blob/7.8.1/src/internal/testing/TestScheduler.ts#L18

@gustavohenke gustavohenke merged commit bb8436b into main Jan 12, 2024
@gustavohenke gustavohenke deleted the exponential-backoff branch January 12, 2024 20:14
@mscottnelson
Copy link

mscottnelson commented Jan 12, 2024

Very nice! Looks great! Thank you for adding this feature

@gustavohenke
Copy link
Member Author

gustavohenke commented Sep 8, 2024

🚢 This is now available in v9.0.0!
https://github.com/open-cli-tools/concurrently/releases/tag/v9.0.0

@anthonyspencer88 anthonyspencer88 mentioned this pull request Sep 30, 2024
Open
@Rosenstein Rosenstein mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paescuj paescuj Awaiting requested review from paescuj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v9

Development

Successfully merging this pull request may close these issues.

Feature Request: Exponential backoff

4 participants

@gustavohenke @coveralls @mscottnelson