feat(tui): Add confirmation prompt for enabling full access approvals #4980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-hurd-oai
commented
Oct 9, 2025
f4660af to
6b89b41
Compare
6b89b41 to
7e82358
Compare
jif-oai
approved these changes
Oct 15, 2025
| } | ||
|
|
||
| /// Persist the acknowledgement flag for the full access warning prompt. | ||
| pub fn set_hide_full_access_warning(codex_home: &Path, acknowledged: bool) -> anyhow::Result<()> { |
Collaborator
There was a problem hiding this comment.
We must definitely refactor this... this is not normal that we need to write in a file etc just to set a flag
Also this should not be part of codex-core. The crate should be agnostic of those TUI details
Collaborator
Author
There was a problem hiding this comment.
Strong agree on needing a new interface
| features: Features::with_defaults(), | ||
| active_profile: Some("gpt3".to_string()), | ||
| windows_wsl_setup_acknowledged: false, | ||
| notices: Default::default(), |
Collaborator
There was a problem hiding this comment.
Outside of scope but we should impl Default for Config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation screen when a user attempts to select Full Access via the
/approvalsflow in the TUI.If the user selects the remember option, the preference is persisted to config.toml as
full_access_warning_acknowledged, so they will not be prompted again.Testing
https://chatgpt.com/codex/tasks/task_i_68e6c5c458088322a28efa3207058180