Simplify toString assertion#554
Merged
timtebeek merged 3 commits intoopenrewrite:mainfrom Jul 24, 2024
Merged
Conversation
Instead of using:
```
assertThat(cat.toString()).isEqualTo("animal");
```
Could use:
```
assertThat(cat).hasToString("animal");
```
Signed-off-by: Marvin Froeder <[email protected]>
timtebeek
reviewed
Jul 24, 2024
src/test/java/org/openrewrite/java/testing/assertj/MigrateChainedAssertToAssertJTest.java
Outdated
Show resolved
Hide resolved
…nedAssertToAssertJTest.java
timtebeek
approved these changes
Jul 24, 2024
Member
timtebeek
left a comment
There was a problem hiding this comment.
Nice addition, thanks! Love how you keep turning up with more of these replacements, and how easy they've become to add and improve tests suites.
Contributor
Author
You never know when one of these might land me a role at open rewrite. And I used it a lot on my day job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using:
Could use:
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist