Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: first release wrong for submodules with custom range #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 2 commits into from
Apr 26, 2025
Merged

fix: first release wrong for submodules with custom range #1136

orhun merged 2 commits into from
Apr 26, 2025

Conversation

@lehmanju
Copy link
Contributor

@lehmanju lehmanju commented Apr 25, 2025 •
edited
Loading

Description

Motivation and Context

Submodule changelogs are wrong if a custom range is supplied. The issue is that during submodule recursion, the previous release of the first release doesn't have a commit id attached. As a consequence the first release contains all commits, completely ignoring the range.

How Has This Been Tested?

Added a github fixture test.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lehmanju lehmanju requested a review from orhun as a code owner April 25, 2025 10:12
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.11%. Comparing base (cbeca6d) to head (7bde106).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1136      +/-   ##
==========================================
- Coverage   40.13%   40.11%   -0.02%     
==========================================
  Files          21       21              
  Lines        1899     1900       +1     
==========================================
  Hits          762      762              
- Misses       1137     1138       +1
Flag Coverage Δ
unit-tests 40.11% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lehmanju lehmanju force-pushed the submodules-custom-range branch from 64fcf45 to 84f490e Compare April 25, 2025 12:44
orhun
orhun reviewed Apr 26, 2025
View reviewed changes
orhun
orhun approved these changes Apr 26, 2025
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@orhun orhun merged commit 451a694 into orhun:main Apr 26, 2025
78 of 80 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lehmanju @codecov-commenter @orhun