Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Aug 16, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 16, 2025 14:12
@Boshen Boshen requested a review from camc314 as a code owner August 16, 2025 14:12
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Aug 16, 2025
Copy link
Member Author

Boshen commented Aug 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the tsgolint integration by adding support for help messages in diagnostic output and includes a minor justfile improvement for watch mode.

  • Add help message field to RuleMessage struct and handle it in diagnostic conversion
  • Update diagnostic creation to use explicit OxcDiagnostic::from() instead of .into()
  • Add --disable-nested-config flag to watch-oxlint command for better development experience

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
justfile Adds --disable-nested-config flag to the watch-oxlint command
crates/oxc_linter/src/tsgolint.rs Implements help message support in tsgolint diagnostics and improves code clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codspeed-hq bot commented Aug 16, 2025

CodSpeed Instrumentation Performance Report

Merging #13143 will not alter performance

Comparing 08-16-feat_linter_consume_help_message_from_tsgolint (bcf9d76) with main (7cf6186)

Summary

✅ 34 untouched benchmarks

@Boshen Boshen merged commit 09b597f into main Aug 16, 2025
26 checks passed
@Boshen Boshen deleted the 08-16-feat_linter_consume_help_message_from_tsgolint branch August 16, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant