Rebalance - #842
Merged
Merged
Conversation
This was referenced Jul 31, 2026
AlexTMjugador
approved these changes
Jul 31, 2026
| Deflater::Libdeflater { compression } => compression < 12 && opts.fast_evaluation, | ||
| _ => false, | ||
| // Try to infer the optimization level from the settings | ||
| // TODO: [v11] Store the level in the settings |
Member
There was a problem hiding this comment.
Just a note for our future selves: when using Oxipng through its API, the settings in use may not exactly match any of the predefined optimization levels. Because of that, I'd suggest keeping the logic here tied to the specific parameters that make transformations less effective, rather than to fixed optimization level values.
|
@andrews05 So, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a notable rebalancing of the levels, which hasn't happened since v7. Hopefully the final PR before the 10.2 release.
I've tried to make the progression more consistent here by only enabling additional things as we go up, rather than trying micro-balance each level by potentially disabling things that were enabled at a lower level.
Summary:
fast, add filters 1,6fast, add filters 1,6, enable battiatoResults:
Closes #755
Closes #775
Supersedes #827
Supersedes #838