Update code tag validation to conform to Figlet specification. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative values are permitted. Values are checked to ensure they are within allowable range.
Owner
|
This checks out (https://github.com/patorjk/figlet.js/blob/main/doc/figfont.txt#L1069), thank you for finding this and thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the character code values, ensuring that they conform to the Figlet specification.
The existing code seems to allow negative hex values (including -1), but not negative decimal or negative octal values.
This PR allows negative hex, dec, and octal values for the character code. This PR also checks to ensure the values are within the range in the Figlet specification and that the value is not -1.