Enable the godot linter #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arve Knudsen <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables the godot linter in the golangci.yml configuration and fixes all the resulting linting issues by adding missing periods to Go comments throughout the codebase.
- Enabled the
godotlinter in the configuration - Added trailing periods to comment lines that were missing them
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .golangci.yml | Uncommented the godot linter to enable it |
| promslog/slog.go | Added period to Config struct comment |
| promslog/flag/flag.go | Added period to AddFlags function comment |
| model/time.go | Added periods to Set and Type method comments |
| model/metric.go | Added periods to EscapingKey comment and lower function comment |
| expfmt/expfmt_test.go | Simplified and corrected test function comment with proper period |
| config/http_config_test.go | Added period to isEmptyNonNilURL function comment |
| config/http_config.go | Added periods to UnmarshalYAML method comments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Arve Knudsen <[email protected]>
ywwg
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the godot linter and fix issues.