[BUGFIX] Scraping: Tolerance should be max 1% of interval #13737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code set it at minimum 1%, which was not intended. Signed-off-by: Bryan Boreham <[email protected]>
|
Thanks, prometheus/cmd/prometheus/main.go Line 426 in 3d16d39 |
|
But we didn't mention that alignments were skipped if the tolerance is greater than 1% of the scrape interval, so we can keep it like that. Your call. |
|
The docstring didn't explain much before, so I don't feel it's essential to improve it in this PR. |
beorn7
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code set it at minimum 1%, which was not intended.
Fixes #13730