sessions: fix hooks type#7425
Merged
nateprewitt merged 1 commit intoMay 11, 2026
Merged
Conversation
Member
|
I'm on mobile but this seems right based on what you described. I'll take a look at some point today. Thanks, @bastimeyer! |
nateprewitt
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hookkeyword inSession.request()should be of typeHooksInputType | None, notHooksType.This is already correctly defined in
models.Request.__init__():requests/src/requests/models.py
Lines 283 to 333 in dc9dbdf
But
sessions.Session.request()and the associated_types.BaseRequestKwargsare wrong:requests/src/requests/sessions.py
Lines 557 to 618 in dc9dbdf
requests/src/requests/_types.py
Lines 145 to 156 in dc9dbdf