This repository was archived by the owner on Apr 11, 2026. It is now read-only.
fix case of checking truthiness of NotImplemented#1298
Merged
Conversation
7978cb8 to
293f4c3
Compare
CodSpeed Performance ReportMerging #1298 will not alter performanceComparing Summary
|
|
Thanks for the fix 👍 |
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 20, 2025
…c-core#1298) Original-commit-hash: 88a8a30
davidhewitt
added a commit
to pydantic/pydantic
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
At the moment when checking for non-negative integers, we can get false-postives from types that aren't integer.
e.g. the original logic was equivalent to
... because comparisons between strings and integers are not implemented, and the dunder method does not raise type errors on
NotImplemented.Related issue number
Fixes pydantic/pydantic#9328
Checklist
pydantic-core(except for expected changes)