draft: Improve scdoc analyze_text #2402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e77deb to
2bbfde2
Compare
2bbfde2 to
b54765d
Compare
|
@stacyharper This PR is marked “draft”, does that still reflect its status? |
I'm not very familiar with pygments. This is still a RFC to me. If you guys thinks it is good, or could be improved, let me knows |
|
It looks good :) Sorry, I misinterpreted the draft status as "I still want to make changes to it, don't merge yet". Merging this now. |
|
Not sure why CI didn't run on this PR, or maybe I somehow missed the approval step... Anyway it's failing on master now due to a missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2399