Minor docs fix #1511
Merged
Minor docs fix #1511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Jun 2, 2023
|
|
||
| !!! tip | ||
| Currently, "build" supports arrays for options, but "pip" only supports | ||
| single values. |
There was a problem hiding this comment.
Not needed for this PR, but this is not true anymore, pip supports arrays, as long as we don't stop it in cibuildwheel (which I don't think we do), it should just work.
There was a problem hiding this comment.
Yes, pip support for multiple config settings with the same key was added in 23.1. Here's a link to the changelog: https://pip.pypa.io/en/stable/news/#v23-1
There was a problem hiding this comment.
That reminds me, this would still be true for 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor docs fix. It looks like it was originally a copy-paste-modify but with the modify stage missing.
Whilst I am here, thanks very much for such a useful project.