Update requires#955
Merged
Merged
Conversation
Author
|
Didn't see this before creating this PR: #921 is an issue about the inconsistency in the docs |
Contributor
|
lets use the examples from https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html as base for safety the backend needs to be added, wheel is auto-added these days by setuptools internals |
RonnyPfannschmidt
approved these changes
Oct 11, 2023
RonnyPfannschmidt
left a comment
Contributor
There was a problem hiding this comment.
Lovely, thanks 👍
Author
|
@RonnyPfannschmidt I've updated the PR. Not 100% sure I understood what you meant so I hope it's alright :) There's still a small inconsistency with the minimum setuptools required. The examples now all say >=64, but the text and the setuptools integration check say >=61. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the requires line in
usage.mdandREADME.mdwas inconsistent with how it was specified elsewhere (customizing.mdandindex.md).