Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[doc] Fix minor typo in example/parametrize.rst#12784

Merged
webknjaz merged 1 commit into
pytest-dev:mainfrom
svenevs:fix/docs-example-parametrize-minor-typo
Sep 7, 2024
Merged

[doc] Fix minor typo in example/parametrize.rst#12784
webknjaz merged 1 commit into
pytest-dev:mainfrom
svenevs:fix/docs-example-parametrize-minor-typo

Conversation

@svenevs

@svenevs svenevs commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

A space is needed for ZeroDivisionError to render as teletype.

I don't have 3.12 on this computer so I did not build the docs locally to test. However, compare renderings of ZeroDivisionError with current main

https://github.com/pytest-dev/pytest/blob/main/doc/en/example/parametrize.rst#parametrizing-conditional-raising

and this pr

https://github.com/svenevs/pytest/blob/fix/docs-example-parametrize-minor-typo/doc/en/example/parametrize.rst#parametrizing-conditional-raising

Thanks for the docs, I definitely want to start adding some test id's for what I'm working on (current output = chaos xD). Was easy to find in the docs! 🙂

A space is needed for ``ZeroDivisionError`` to render as teletype.
@svenevs

svenevs commented Sep 6, 2024

Copy link
Copy Markdown
Contributor Author

Hmmmm ok the pr docs render as expected, I'm not sure what to do about the changelog entry. Let me know if you prefer to dismiss it, or if I should create an issue just to have this PR close it.

@webknjaz webknjaz enabled auto-merge September 7, 2024 00:13
@webknjaz webknjaz added skip news used on prs to opt out of the changelog requirement backport 8.3.x labels Sep 7, 2024
@webknjaz webknjaz merged commit 57cccf7 into pytest-dev:main Sep 7, 2024
@patchback

patchback Bot commented Sep 7, 2024

Copy link
Copy Markdown

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/57cccf7f44b73e95a4cd2b09376a00ab35df5ec2/pr-12784

Backported as #12785

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Sep 7, 2024
…inor-typo

[doc] Fix minor typo in example/parametrize.rst

(cherry picked from commit 57cccf7)
webknjaz added a commit that referenced this pull request Sep 7, 2024
…7cccf7f44b73e95a4cd2b09376a00ab35df5ec2/pr-12784

[PR #12784/57cccf7f backport][8.3.x] [doc] Fix minor typo in example/parametrize.rst
@svenevs svenevs deleted the fix/docs-example-parametrize-minor-typo branch September 7, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news used on prs to opt out of the changelog requirement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants