Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

codejedi365
Copy link
Contributor

@codejedi365 codejedi365 commented Jan 12, 2025

Purpose

Adds a conventional commits parser designed for monorepos

How did you test?

Added 3 new monorepo fixtures and rebuild tests for various types of monorepo workflows. Specifically:

  • Trunk only development for a 2 package monorepo
  • GitHub Flow development strategy for a 2 package monorepo with squash commits
  • GitHub Flow development strategy for a 2 package monorepo with merge commits

@codejedi365 codejedi365 self-assigned this Jan 12, 2025
@marc-at-brightnight
Copy link

Added docs. Realizing slowly I need this feature ✊🏼

@spastorclovr
Copy link

Would love to this this being merge as we are facing the issue of versioning being calculated even on commits not related to the sub project. Any chance on having this merged "soonishly"?

Thx!

@codejedi365
Copy link
Contributor Author

@spastorclovr, thanks for the priority request comment, I've been working on other things as the complexity of validation is not trivial. Will try to get it merged over the next month. Meanwhile, you can add it as a custom parser into your repository with your config pointing to your repository file. It is manually tested and validated by myself and @marc-at-brightnight for his repo so it should work for your environment today.

@spastorclovr
Copy link

Thank you for taking the time to respond! I Will try as suggested. Thx for this project! (currently using it with dagger.io which needs a ready-to-use function which I will do ASAP)

@github-actions github-actions bot removed the stale label May 23, 2025
@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch 2 times, most recently from e9a1908 to d3856b5 Compare May 26, 2025 16:26
@markdoerr
Copy link

Dear developers,
I would also like to use this new feature :)
What is the current status of this MR ?
Thanx

@codejedi365
Copy link
Contributor Author

@markdoerr, please see comments above. Not ready yet to add it to the baseline but it is available as a custom parser today.

@Triquetra
Copy link

I am eagerly anticipating the release of this feature.

In the meantime, how do I use the monorepo-parser as a custom parser?

@codejedi365
Copy link
Contributor Author

codejedi365 commented Jun 19, 2025

how do I use the monorepo-parser as a custom parser?

Review the documentation on how to set a custom parser value.

And you can use this demo repo as well mirrored off of another contributors described monorepo structure.

It supports file path matching as the primary mechanism for differentiation of projects then as a secondary filter, the use of scope prefixes.

@codejedi365 codejedi365 mentioned this pull request Jun 26, 2025
@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch from d3856b5 to 8ea6dec Compare July 27, 2025 18:47
@codejedi365 codejedi365 marked this pull request as ready for review July 27, 2025 18:48
@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch 2 times, most recently from 4b462ca to a212f55 Compare July 27, 2025 19:51
@JonZeolla
Copy link
Contributor

@codejedi365 thank you for the recent activity on this. I have found this recently went from a nice to have for me, to a need to have. I will start by adding this as a custom parser but I'd like to offer that my team could assist with testing or similar if you'd like. I will report back if I encounter significant issues.

@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch from 15f0c67 to fa9b2c6 Compare July 28, 2025 01:54
@codejedi365
Copy link
Contributor Author

codejedi365 commented Jul 28, 2025

@codejedi365 thank you for the recent activity on this. I have found this recently went from a nice to have for me, to a need to have. I will start by adding this as a custom parser but I'd like to offer that my team could assist with testing or similar if you'd like. I will report back if I encounter significant issues.

@JonZeolla, thanks for the pep talk, lol! I have to duplicate and refactor the entire e2e testing suite to support monorepos. This is a beast. Likewise, I also have a project using a monorepo which gives me the reason to make this standard. Please indicate if you do have any issues. It has been tested before in the repo: https://github.com/codejedi365/psr-monorepo-poweralpha, which was a demo for another user but I do keep modifying this to make it work within PSR. You may find that you want to just combine the Options class with the Parser class into the same file to allow you to just specify the parser via a file path. I plan to write automated tests for: one trunk-only repo with one release channel, 2 GitHub Flow repos (with 1 and 2 release channels respectively) initially. The changelogs will be internal to the packages but use a common templates directory.

Given that human git strategies rarely maintain the strict standard as my automated tests do, it will be helpful if you identify flaws with the current implementation.

@codejedi365
Copy link
Contributor Author

codejedi365 commented Aug 4, 2025

That's unusual. I'm curious what were the errors you got with the change to 10.3? 10.3 was supposed to be simple GitHub Actions updates (idk, I wrote it last weekend and brain dumped it for monorepos)

I've been working on the PR all weekend and there were some bugs with this parser refactor but a type error was not one of them. Although ruff may have fixed it automatically. I have not pushed the updated code yet.

Instead of using parentheses just insert this line at the top:

from __future__ import annotations 

This tells Python to evaluate types last (effectively ignore all type syntax unless required) at runtime.

@JonZeolla
Copy link
Contributor

Just for posterity (you already saw) the 10.3 issue I hit was unrelated to this. #1307

Ah yes that's likely the discrepancy. I don't have from __future__ import annotations in my version

@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch from fa9b2c6 to 37664fd Compare August 5, 2025 07:05
@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch 6 times, most recently from 27b042b to 1e80134 Compare September 2, 2025 17:24
@codejedi365 codejedi365 force-pushed the feat/monorepo-parser branch 2 times, most recently from 90128c2 to 2260875 Compare September 7, 2025 01:43
@codejedi365 codejedi365 merged commit e18f866 into python-semantic-release:master Sep 8, 2025
9 checks passed
@codejedi365 codejedi365 deleted the feat/monorepo-parser branch September 8, 2025 06:37
@codejedi365
Copy link
Contributor Author

🎉 This PR has been published as part of v10.4.0 🎉

You can find more information about this release on the GitHub Releases page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants