fix(github-actions): add filesystem UID/GID fixer after action workspace modification #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es the github workspace
fe8a87e to
57e1d2d
Compare
🎉 This PR has been published as part of v10.0.2 🎉You can find more information about this release on the GitHub Releases page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
I found that here on PSR we had some issues writing the partial tags occasionally after PSR had created a commit. I discovered that this was because while in the Docker container, the commit action had turned certain files within the git repository (which is mounted into the container) to root owned files. Then afterword if the sha1 for the tag matched the first few characters of the sha1 of the commit then it would collide and fail with permissions errors on the
.git/objects/folder.How did you test?
I ran this on my repository fork with a full file listing of the
.git/directory. I could see in comparison to when this project released to after this fix was implemented how the file ownership was corrected fromroot:roottorunner:docker.PR Completion Checklist
Reviewed & followed the Contributor Guidelines
Changes Implemented & Validation pipeline succeeds
Commits follow the Conventional Commits standard
and are separated into the proper commit type and scope (recommended order: test, build, feat/fix, docs)
N/A
Appropriate Unit tests added/updatedN/A
Appropriate End-to-End tests added/updatedN/A
Appropriate Documentation added/updated and syntax validated for sphinx build (see Contributor Guidelines)