-
-
Notifications
You must be signed in to change notification settings - Fork 411
[UnusedImport] Different letter case for classes + optimization #6362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samsonasik
merged 10 commits into
rectorphp:main
from
jorgsowa:fix/unused-import-different-letter-case
Oct 11, 2024
Merged
[UnusedImport] Different letter case for classes + optimization #6362
samsonasik
merged 10 commits into
rectorphp:main
from
jorgsowa:fix/unused-import-different-letter-case
Oct 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Oct 8, 2024
samsonasik
reviewed
Oct 9, 2024
jorgsowa
commented
Oct 9, 2024
samsonasik
reviewed
Oct 10, 2024
tests/Issues/NamespacedUse/Fixture/skip_conflict_last_name_insensitive.php.inc
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Oct 10, 2024
samsonasik
reviewed
Oct 10, 2024
tests/Issues/NamespacedUse/Fixture/skip_different_letter_case.php.inc
Outdated
Show resolved
Hide resolved
…ensitive.php.inc Co-authored-by: Abdul Malik Ikhsan <[email protected]>
…php.inc Co-authored-by: Abdul Malik Ikhsan <[email protected]>
samsonasik
approved these changes
Oct 11, 2024
Let's give it a try once more, thank you @jorgsowa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try of #6350
Fixes the
UnusedImportRemovingPostRector
rule when the imported namespace doesn't match the letter case in the code, by comparing all names in lowercase, except consts, because of their case sensitivity.Additionally:
Early return for cases when no usage of imported namespaces has been found.
Example:
https://getrector.com/demo/f2508805-2d69-4792-908b-3555589439e1
To do: