Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 22, 2025

Reverts #6258 and #5547


I'm going through some old rules and see if they're used. Goal is to push too specific rules down to local custom or external projects, to make Rector core leaner and more universal to typical user.

I could not find these 2 on Github, nor Rector Laravel:

Saying that, I'll deprecate these 2 and remove them. Just headsup 👍

If they're used, I recommend adding them to Laravel specific sets. It might be easier to add these types, without having exact Application type. I know Laravel uses lot of magic and types can be lost easily. But this rule would be still useful in ServiceProvider context.

@TomasVotruba TomasVotruba changed the title tv cleanup [depre] Deprecate 2 configurable-only, never used closure param rules as too specific Oct 22, 2025
@TomasVotruba TomasVotruba force-pushed the tv-cleanup branch 2 times, most recently from d214170 to 862d777 Compare October 22, 2025 19:40
@TomasVotruba TomasVotruba changed the title [depre] Deprecate 2 configurable-only, never used closure param rules as too specific [depre] Deprecate 3 configurable-only, never used closure param rules as too specific Oct 22, 2025
…tionRector as too specific and not useful for general community rules
@TomasVotruba TomasVotruba merged commit 82d8975 into main Oct 22, 2025
52 checks passed
@TomasVotruba TomasVotruba deleted the tv-cleanup branch October 22, 2025 19:51
@samsonasik
Copy link
Member

/cc @peterfox FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants