Added custom Claude command + XNACK command support#4030
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fee6e93. Configure here.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds contributor tooling/docs for AI-assisted command additions and implements Redis Streams XNACK support in the core client API, along with new sync/async integration tests gated on Redis >= 8.8.0.
Changes:
- Add
xnack()toredis/commands/core.py(sync + asyncio typing overloads) with argument validation and command assembly. - Add integration tests for
XNACKbehavior and error handling (sync + asyncio). - Add contributor documentation and Claude skill/template files for adding new Redis command support.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
redis/commands/core.py |
Adds xnack() command implementation and typing overloads. |
tests/test_commands.py |
Adds sync integration tests for XNACK (Redis >= 8.8.0). |
tests/test_asyncio/test_commands.py |
Adds asyncio integration tests for XNACK (Redis >= 8.8.0). |
specs/redis_commands_guide.md |
New guide describing command API/spec workflow and repo structure. |
CONTRIBUTING.md |
Documents AI-driven contribution workflow and available CLI commands. |
.claude/commands/add-new-command.md |
New Claude “skill” instructions to add command support from a spec. |
.claude/command-specification-template.md |
New template for authoring command specifications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
petyaslavova
reviewed
Apr 9, 2026
petyaslavova
added a commit
that referenced
this pull request
May 26, 2026
* Added custom Claude command + XNACK command support * Updated command description * Update CONTRIBUTING.md Co-authored-by: Copilot <[email protected]> * Update specs/redis_commands_guide.md Co-authored-by: Copilot <[email protected]> * Update specs/redis_commands_guide.md Co-authored-by: Copilot <[email protected]> * Update specs/redis_commands_guide.md Co-authored-by: Copilot <[email protected]> * Update .claude/commands/add-new-command.md Co-authored-by: Copilot <[email protected]> * Update .claude/command-specification-template.md Co-authored-by: Copilot <[email protected]> * Fixed grammar and version constraints * Updated spellcheck * Updated 8.8 test image --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: petyaslavova <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
This PR contains:
CONTRIBUTING.mdabout AI agent contributions.Execute new command via CLI interface:
Augment CLI
Claude CLI
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Note
Medium Risk
Introduces a new public client API method that constructs a low-level Redis command; incorrect argument encoding/order could cause runtime errors, though coverage is mitigated by added integration tests.
Overview
Adds first-class client support for Redis Streams
XNACK, including sync/async overloads, argument validation (mode, required IDs, non-negativeretrycount), and support forRETRYCOUNT/FORCEoptions.Expands integration test coverage (sync + asyncio, Redis >= 8.7.2) for
XNACKmodes and edge cases, and adds contributor tooling/docs: a Claude “add-new-command” skill plus a command specification template and a Redis command implementation guide;CONTRIBUTING.mdand the spelling wordlist are updated accordingly.Reviewed by Cursor Bugbot for commit 3ffd26b. Bugbot is set up for automated code reviews on this repo. Configure here.