Adding support for new COUNT aggregator for some sorted set commands - ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE#4034
Merged
petyaslavova merged 3 commits intoApr 21, 2026
Conversation
…- ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 130f52a. Configure here.
vladvildanov
approved these changes
Apr 21, 2026
petyaslavova
added a commit
that referenced
this pull request
May 26, 2026
…- ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE (#4034)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add COUNT aggregator support for sorted set commands (ZINTER, ZINTERSTORE, ZUNION, ZUNIONSTORE)
This PR adds support for the new
COUNTaggregation mode introduced in Redis 8.8.0 for sorted set aggregate commands:ZINTER,ZINTERSTORE,ZUNION, andZUNIONSTORE. TheCOUNTaggregator ignores original element scores and instead counts weighted set membership — each element's resulting score is the sum of the weights of the input sets that contain it. When all weights are 1 (the default), the score simply equals the number of input sets containing the element.The implementation updates the
_zaggregatehelper inredis/commands/core.pyto accept"COUNT"as a valid aggregate option alongside the existingSUM,MIN, andMAXmodes.The error message for invalid aggregate values has been updated accordingly.
Docstrings for
zinter,zinterstore,zunion, andzunionstorehave been expanded to document all four aggregation modes with clear descriptions and score formulas.Comprehensive tests have been added across all test suites — sync, async, sync cluster, and async cluster — covering both basic
COUNTaggregation andCOUNTwith custom weights.Note
Low Risk
Small, localized change to argument validation for sorted-set aggregate commands plus new tests; low risk aside from potential compatibility differences on older Redis versions (tests are version-gated).
Overview
Adds support for the new
COUNTAGGREGATEmode for sorted-set aggregate commands by allowingCOUNTin the internal_zaggregatecommand builder (and updating the invalid-aggregateDataErrormessage).Updates docstrings for
zinter,zinterstore,zunion, andzunionstoreto documentCOUNTsemantics and formulas, and adds version-gated tests (sync/async, cluster/non-cluster) coveringCOUNTbehavior with and without weights.Reviewed by Cursor Bugbot for commit 7c7031b. Bugbot is set up for automated code reviews on this repo. Configure here.