Fix flaky tests#4071
Merged
Merged
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
The test still verifies that 10.5 seconds is preserved as more than 10 seconds, but it no longer assumes the acquire/PTTL round trip finishes within 100 ms, which is too tight for cluster runs.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 98a523f. Configure here.
…in separate PR This reverts commit db64244.
vladvildanov
approved these changes
May 20, 2026
petyaslavova
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Mostly test-only timing/timeout adjustments to reduce flakiness, plus a small behavior change in
CacheProxyConnection.send_commandto always drain pending push messages which could impact client-side caching behavior/performance.Overview
Reduces flakiness across lock, pubsub, connection-pool, vector-set, and hybrid-search tests by loosening timing/TTL assertions, synchronizing publisher start, and making hybrid-search timeout verification more deterministic (including shorter pytest timeouts).
Adds local OpenTelemetry benchmark documentation and a separate
benchmarks/requirements.txtfor the OTLP gRPC exporter, and switches dev dependencies fromopentelemetry-exporter-otlpto the explicit OTLP/HTTP package.Adjusts client-side caching invalidation handling in
redis/connection.pyto always drain pending push messages from the cached entry’s connection before re-checking cache validity.Reviewed by Cursor Bugbot for commit 0c48937. Bugbot is set up for automated code reviews on this repo. Configure here.