More consistent usage of err

webpro · webpro · commit 4be5b10c7b99 · 2024-07-08T19:36:59.000+02:00
diff --git a/lib/plugin/github/GitHub.js b/lib/plugin/github/GitHub.js
@@ -105,8 +105,8 @@ class GitHub extends Release {
       const { data } = await this.client.users.getAuthenticated();
       this.setContext({ username: data.login });
       return true;
-    } catch (error) {
-      this.debug(error);
+    } catch (err) {
+      this.debug(err);
       return false;
     }
   }
@@ -120,8 +120,8 @@ class GitHub extends Release {
       this.log.verbose(`octokit repos#checkCollaborator (${username})`);
       await this.client.repos.checkCollaborator(options);
       return true;
-    } catch (error) {
-      this.debug(error);
+    } catch (err) {
+      this.debug(err);
       return false;
     }
   }
diff --git a/lib/shell.js b/lib/shell.js
@@ -78,12 +78,12 @@ class Shell {
       this.log.verbose(stdout, { isExternal });
       debug({ command, options, stdout, stderr });
       return Promise.resolve(stdout || stderr);
-    } catch (error) {
-      if (error.stdout) {
-        this.log.log(`\n${error.stdout}`);
+    } catch (err) {
+      if (err.stdout) {
+        this.log.log(`\n${err.stdout}`);
       }
-      debug({ error });
-      return Promise.reject(new Error(error.stderr || error.message));
+      debug(err);
+      return Promise.reject(new Error(err.stderr || err.message));
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,8 @@ class GitHub extends Release {`
`105`	`105`	`const { data } = await this.client.users.getAuthenticated();`
`106`	`106`	`this.setContext({ username: data.login });`
`107`	`107`	`return true;`
`108`		`- } catch (error) {`
`109`		`- this.debug(error);`
	`108`	`+ } catch (err) {`
	`109`	`+ this.debug(err);`
`110`	`110`	`return false;`
`111`	`111`	`}`
`112`	`112`	`}`
`@@ -120,8 +120,8 @@ class GitHub extends Release {`
`120`	`120`	this.log.verbose(`octokit repos#checkCollaborator (${username})`);
`121`	`121`	`await this.client.repos.checkCollaborator(options);`
`122`	`122`	`return true;`
`123`		`- } catch (error) {`
`124`		`- this.debug(error);`
	`123`	`+ } catch (err) {`
	`124`	`+ this.debug(err);`
`125`	`125`	`return false;`
`126`	`126`	`}`
`127`	`127`	`}`
Original file line number	Diff line number	Diff line change
`@@ -78,12 +78,12 @@ class Shell {`
`78`	`78`	`this.log.verbose(stdout, { isExternal });`
`79`	`79`	`debug({ command, options, stdout, stderr });`
`80`	`80`	`return Promise.resolve(stdout \|\| stderr);`
`81`		`- } catch (error) {`
`82`		`- if (error.stdout) {`
`83`		- this.log.log(`\n${error.stdout}`);
	`81`	`+ } catch (err) {`
	`82`	`+ if (err.stdout) {`
	`83`	+ this.log.log(`\n${err.stdout}`);
`84`	`84`	`}`
`85`		`- debug({ error });`
`86`		`- return Promise.reject(new Error(error.stderr \|\| error.message));`
	`85`	`+ debug(err);`
	`86`	`+ return Promise.reject(new Error(err.stderr \|\| err.message));`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`	`}`