Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

This applies some code simplifications from the most recent Rust toolchain/clippy updates.

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 6:12pm

Copy link

github-actions bot commented Dec 20, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#lifetimes

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-6awvmgcis-rollup-js.vercel.app/repl/?pr=5769

Copy link

Performance report

  • BUILD: 8197ms, 727 MB
    • initialize: 0ms, 26.6 MB
    • generate module graph: 3130ms, 552 MB
      • generate ast: 1517ms, 545 MB
    • sort and bind modules: 449ms, 598 MB
    • mark included statements: 4632ms, 727 MB
      • treeshaking pass 1: 1558ms, 692 MB
      • treeshaking pass 2: 744ms, 720 MB
      • treeshaking pass 3: 296ms, 723 MB
      • treeshaking pass 4: 278ms, 723 MB
      • treeshaking pass 5: 318ms, 726 MB
      • treeshaking pass 6: 263ms, 734 MB
      • treeshaking pass 7: 245ms, 728 MB
      • treeshaking pass 8: 238ms, 737 MB
      • treeshaking pass 9: 218ms, 734 MB
      • treeshaking pass 10: 221ms, 732 MB
      • treeshaking pass 11: 218ms, 727 MB
  • GENERATE: 895ms, 979 MB
    • initialize render: 0ms, 871 MB
    • generate chunks: 90ms, 873 MB
      • optimize chunks: 0ms, 874 MB
    • render chunks: 785ms, 958 MB
    • transform chunks: 19ms, 979 MB
    • generate bundle: 0ms, 979 MB

@lukastaegert lukastaegert merged commit f116952 into master Dec 20, 2024
41 checks passed
@lukastaegert lukastaegert deleted the lifetimes branch December 20, 2024 18:43
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (dadd488) to head (c68f6ae).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5769   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         259      259           
  Lines        8085     8085           
  Branches     1362     1362           
=======================================
  Hits         8005     8005           
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant