Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5814

Description

Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:11am

Copy link

github-actions bot commented Jan 31, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/5814

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-8umc8alj5-rollup-js.vercel.app/repl/?pr=5818

Copy link

github-actions bot commented Jan 31, 2025

Performance report

  • BUILD: 7655ms, 730 MB
    • initialize: 0ms, 27.3 MB
    • generate module graph: 2851ms, 550 MB
      • generate ast: 1262ms (-47ms, -3.6%), 543 MB
    • sort and bind modules: 405ms (-13ms, -3.0%), 595 MB
    • mark included statements: 4397ms, 730 MB
      • treeshaking pass 1: 1404ms (-41ms, -2.9%), 699 MB
      • treeshaking pass 2: 695ms (-15ms, -2.2%), 716 MB
      • treeshaking pass 3: 294ms, 727 MB
      • treeshaking pass 4: 275ms, 731 MB
      • treeshaking pass 5: 317ms, 733 MB
      • treeshaking pass 6: 261ms, 734 MB
      • treeshaking pass 7: 246ms, 733 MB
      • treeshaking pass 8: 238ms, 729 MB
      • treeshaking pass 9: 220ms, 730 MB
      • treeshaking pass 10: 219ms, 737 MB
      • treeshaking pass 11: 217ms, 730 MB
  • GENERATE: 753ms (+21ms, +2.9%), 974 MB
    • initialize render: 0ms, 868 MB
    • generate chunks: 78ms, 881 MB
      • optimize chunks: 0ms, 870 MB
    • render chunks: 654ms (+18ms, +2.8%), 948 MB
    • transform chunks: 17ms, 974 MB
    • generate bundle: 0ms, 974 MB

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.79%. Comparing base (f412abd) to head (933d169).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5818   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         260      260           
  Lines        8119     8122    +3     
  Branches     1371     1372    +1     
=======================================
+ Hits         8021     8024    +3     
  Misses         72       72           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@lukastaegert lukastaegert added this pull request to the merge queue Feb 1, 2025
Merged via the queue into master with commit 93c9c0e Feb 1, 2025
41 checks passed
@lukastaegert lukastaegert deleted the fix/5814 branch February 1, 2025 06:31
Copy link

github-actions bot commented Feb 1, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

importAttributesKey not respected for dynamic imports

2 participants