Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Currently, there is no mechanism to ensure throw statements include all properties.

Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 5:49am

Copy link

github-actions bot commented Feb 3, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5824_fix_throw

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-ob3e3tgkc-rollup-js.vercel.app/repl/?pr=5825

Copy link

github-actions bot commented Feb 3, 2025

Performance report

  • BUILD: 7143ms, 755 MB
    • initialize: 0ms, 28 MB
    • generate module graph: 2841ms, 560 MB
      • generate ast: 1271ms, 553 MB
    • sort and bind modules: 397ms, 603 MB
    • mark included statements: 3911ms, 755 MB
      • treeshaking pass 1: 2344ms, 746 MB
      • treeshaking pass 2: 445ms, 750 MB
      • treeshaking pass 3: 379ms, 754 MB
      • treeshaking pass 4: 371ms, 753 MB
      • treeshaking pass 5: 366ms, 755 MB
  • GENERATE: 739ms, 987 MB
    • initialize render: 0ms, 885 MB
    • generate chunks: 74ms, 894 MB
      • optimize chunks: 0ms, 889 MB
    • render chunks: 645ms, 963 MB
    • transform chunks: 16ms, 987 MB
    • generate bundle: 0ms, 987 MB

@printfn
Copy link

printfn commented Feb 3, 2025

Thanks for your fix! I just tried it locally on my codebase and the issue seems to be fixed :)

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.54%. Comparing base (979d628) to head (bba652b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5825   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         269      269           
  Lines        8527     8528    +1     
  Branches     1460     1460           
=======================================
+ Hits         8403     8404    +1     
  Misses         92       92           
  Partials       32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit 32504b3 into master Feb 3, 2025
40 checks passed
@lukastaegert lukastaegert deleted the gh-5824_fix_throw branch February 3, 2025 06:16
Copy link

github-actions bot commented Feb 3, 2025

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup 1.34 discards object properties in throw expression
2 participants