Avoid recursively calling a plugin's resolveId hook with same id and importer #5945
+46
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5945 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 270 270
Lines 8727 8731 +4
Branches 1505 1507 +2
=======================================
+ Hits 8620 8624 +4
Misses 73 73
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukastaegert
reviewed
May 6, 2025
|
Sorry for the long wait. I kept pondering if another approach would be less surprising where we skip plugin hooks for extended criteria, but I still keep coming back that your solution is probably the best compromise, so I will merge it now. |
lukastaegert
approved these changes
May 24, 2025
|
This PR has been released as part of [email protected]. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
skipSelf: truedoes not skip the plugin if it has been called before with the same id and importer #5768Description
#5768 describes why we need to do this.
If chaining plugin hooks' call occurs,
skipwill record called plugins, thus we can break the infinity loop by find matching skippedCall inskip