Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump to v2.29.0 #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2024
Merged

Bump to v2.29.0 #1860

merged 1 commit into from
Apr 4, 2024

Conversation

@bquorning
Copy link
Collaborator

@bquorning bquorning commented Apr 4, 2024 •
edited
Loading

I’m eager to see if the new publish.yml workflow works correctly ✨

Should we include #1854 in this release? Others too?

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning marked this pull request as ready for review April 4, 2024 21:15
@bquorning bquorning requested a review from a team as a code owner April 4, 2024 21:15
@ydah
Copy link
Member

ydah commented Apr 4, 2024

#1854 looked good so I merged it! Let's rebase and release it 🎉.

@bquorning bquorning merged commit acb5ac5 into master Apr 4, 2024
@bquorning bquorning deleted the release branch April 4, 2024 22:12
@ydah
Copy link
Member

ydah commented Apr 4, 2024

@bquorningRSpec/EmptyOutput seems to be remain <<next>> in default.yml

@ydah
Copy link
Member

ydah commented Apr 4, 2024

Uh. Its failing to push because of the branch rules:
https://github.com/rubocop/rubocop-rspec/actions/runs/8561970997/job/23464311900

Run sed -i 's/version:.*$/version: ~/' docs/antora.yml
[master 0b618c0] Switch docs version back
 1 file changed, 1 insertion(+), 1 deletion(-)
remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: 12 of 12 required status checks are expected.        
To https://github.com/rubocop/rubocop-rspec
 ! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/rubocop/rubocop-rspec'

@bquorning
Copy link
Collaborator Author

bquorning commented Apr 4, 2024

At least it’s the very last step that fails, so we still have the gem build/push, tagging and GH release creation happening.

Perhaps there is a way to let GHA write to master branch despite the branch protection rules. I have pushed the Antora config change manually for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ydah ydah ydah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bquorning @ydah