xpath: Fix normalize_space(array) case #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the variable 'string' with 'x' inside the collect block.
…y#110 to validate `REXML::Functions::normalize_space()` functionality
kou
reviewed
Feb 8, 2024
Renamed test_normalize_space2 for better clarity and updated tests to use Array of String for expected data. ruby#110 Co-authored-by: Sutou Kouhei <[email protected]>
kou
approved these changes
Feb 8, 2024
Member
kou
left a comment
There was a problem hiding this comment.
+1
Could you update the PR description before we merge this? We'll use the PR title and description for commit message.
Contributor
Author
|
My apologies for the oversight! Thank you for pointing that out. I've made a slight adjustment to the PR description. Does this look alright to you? |
Member
|
Thanks. I've updated a bit and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: fix GH-110
Fixed a bug in
REXML::Functions.normalize_space(array)and introduced test cases for it:string->x).test_normalize_space_stringstotest/functions/test_base.rb.