Implement Debug trait for Scalar type
#578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This looks good to me, but could you run |
62095f4 to
8ed8cac
Compare
Contributor
Author
|
Sure, done! |
apoelstra
approved these changes
Feb 2, 2023
tcharding
reviewed
Feb 2, 2023
| // Internal represenation is big endian to match what `libsecp256k1` uses. | ||
| // Also easier to implement comparison. | ||
| // Debug impl omitted for now, the bytes may be secret | ||
| #[allow(missing_debug_implementations)] |
Member
There was a problem hiding this comment.
This line could have been removed in this patch.
Contributor
Author
There was a problem hiding this comment.
I'm happy to open a followup PR. Shall I?
Contributor
Author
There was a problem hiding this comment.
I went ahead and did to save time: #579. If it's just a nuisance PR due to its size, I'm happy to close it.
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…calar` type
8ed8cac2fee9ec4f809b87fb8f5fa94d58d8b895 Implement `Debug` trait for `Scalar` type. (Arik Sosman)
Pull request description:
Currently, `Scalar` types do not implement the `Debug` trait, whereas most other types in the library do. Besides that being an upstream requirement for us, I believe it would also be quite useful for users of that type.
Also implements the `Index` traits for `Scalar`.
ACKs for top commit:
apoelstra:
ACK 8ed8cac2fee9ec4f809b87fb8f5fa94d58d8b895
Tree-SHA512: f254859144850e40badf6ace2b2a1b231e5ed224ec60861586cd5f2042167d89c759dc16a1075702bce90d810ac60db924ea8cb20d82099a42fddb2718da12db
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…calar` type
8ed8cac2fee9ec4f809b87fb8f5fa94d58d8b895 Implement `Debug` trait for `Scalar` type. (Arik Sosman)
Pull request description:
Currently, `Scalar` types do not implement the `Debug` trait, whereas most other types in the library do. Besides that being an upstream requirement for us, I believe it would also be quite useful for users of that type.
Also implements the `Index` traits for `Scalar`.
ACKs for top commit:
apoelstra:
ACK 8ed8cac2fee9ec4f809b87fb8f5fa94d58d8b895
Tree-SHA512: f254859144850e40badf6ace2b2a1b231e5ed224ec60861586cd5f2042167d89c759dc16a1075702bce90d810ac60db924ea8cb20d82099a42fddb2718da12db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
Scalartypes do not implement theDebugtrait, whereas most other types in the library do. Besides that being an upstream requirement for us, I believe it would also be quite useful for users of that type.Also implements the
Indextraits forScalar.