Re-export FallibleIterator from tokio-postgres #1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolobarbolini
requested changes
Sep 20, 2025
paolobarbolini
approved these changes
Sep 22, 2025
Member
paolobarbolini
left a comment
There was a problem hiding this comment.
LGTM. Could you squash the commits into one?
Contributor
Author
I think that can be done on merge (if not, I can squash later today). |
Member
That's true, but then there would be no merge commit, just the squashed commit. |
Allows wasm users to import FallibleIterator via tokio-postgres instead of having to define the dependency themselves. Fixes rust-postgres#1210
598468a to
4c3390f
Compare
Contributor
Author
|
Squashed! |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows wasm users to import FallibleIterator via tokio-postgres instead
of having to define the dependency themselves.
Fixes #1210