Add support for shipmonk/name-collision-detector tool#973
Merged
shivammathur merged 4 commits intoJul 17, 2025
Conversation
Co-authored-by: shivammathur <[email protected]>
Copilot
AI
changed the title
[WIP] Create a PR for shipmonk/name-collision-detector, based on previous PRs for adding composer based tools
Add support for shipmonk/name-collision-detector tool
Jul 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #973 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 805 805
Branches 284 285 +1
=========================================
Hits 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shivammathur
requested changes
Jul 17, 2025
Owner
shivammathur
left a comment
There was a problem hiding this comment.
LGTM, please add an entry in the tools section in the README as well similar to how other tools are documented.
Co-authored-by: shivammathur <[email protected]>
Contributor
Author
Added name-collision-detector to the README tools section as requested. The tool is now documented alongside other supported tools in the tools list. (commit a3845d8) |
shivammathur
requested changes
Jul 17, 2025
Co-authored-by: shivammathur <[email protected]>
shivammathur
approved these changes
Jul 17, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
shipmonk/name-collision-detectortool to the setup-php action, following the existing pattern for other ShipMonk composer-based tools.What is name-collision-detector?
The
shipmonk/name-collision-detectoris a fast PHP tool that detects duplicate class, interface, enum, trait, constant, or function names within the same namespace. It helps prevent ambiguous class resolution issues that can cause hard-to-debug problems in PHP projects.Usage
After this PR, users can include the tool in their GitHub Actions workflows:
Changes Made
Added tool configuration in
src/configs/tools.json:composer(installed via Composer)shipmonk/name-collision-detectorscoped(for proper isolation)Added comprehensive test coverage in
__tests__/tools.test.ts:Generated expected output: The tool will be installed using
add_composer_tool name-collision-detector name-collision-detector shipmonk/ scopedBenefits
collision-detector.jsonconfiguration filecomposer-dependency-analyserTesting
This addition enhances the PHP development experience by providing an easy way to catch name collision issues early in the development cycle.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.