test(e2e, Fabric): add e2e test for issue/PR example 658#2900
Merged
Conversation
kkafar
requested changes
May 5, 2025
kkafar
left a comment
Member
There was a problem hiding this comment.
😄 This one is a bit tedious. I haven't checked the runtime behaviour, trusting you here to get it right!
Contributor
Author
|
Yeah, this one is not the most interesting. The test seems to be working fine, I will wait for the CI to pass. We could probably add a lot of different combinations of transparent modals and regular modals but the original issue was mainly about transparent modals - only 2 of them were visible - so I focused on simpler examples in order not to overwhelm our CI in the future :D |
kkafar
approved these changes
May 5, 2025
kkafar
left a comment
Member
There was a problem hiding this comment.
That is fine for a moment. Thanks! The lib really needs this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create e2e test for
Test658.Test658
Test created. It checks that opening multiple modals/transparent modals works correctly.
Changes
Test658screen to allow testing:dangerouslyGetState()togetState()(details)Textwith screen numberTest658apps/src/tests/index.tsTest code and steps to reproduce
CI
Checklist