fix: defaultValue in additional-spring-configuration-metadata.json#1041
Merged
OlgaMaciaszek merged 1 commit intospring-cloud:4.1.xfrom Sep 4, 2024
Merged
fix: defaultValue in additional-spring-configuration-metadata.json#1041OlgaMaciaszek merged 1 commit intospring-cloud:4.1.xfrom
OlgaMaciaszek merged 1 commit intospring-cloud:4.1.xfrom
Conversation
…eric-ids.enabled` is true since version 4.0.0
OlgaMaciaszek
requested changes
Sep 4, 2024
Collaborator
OlgaMaciaszek
left a comment
There was a problem hiding this comment.
Hi @dowenliu-xyz. Thanks for submitting the PR. Looks good, however, could you please submit it against 4.1.x instead of main? Like this, the change will also be included in the 2023.0.x release train.
Contributor
Author
|
Ok, it's fine. And I've noticed that I have make this change base on main branch. Is it ok? |
Collaborator
Yes, looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defaultValue of
spring.cloud.openfeign.circuitbreaker.alphanumeric-ids.enabledistruesince version 4.0.0