@NestedConfigurationProperty doesn't work on records#41251
Closed
acouvreur wants to merge 1 commit into
Closed
Conversation
|
@acouvreur Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@acouvreur Thank you for signing the Contributor License Agreement! |
Add `ElementType.RECORD_COMPONENT` to `NestedConfigurationProperty` and implement `isMarkedAsNested` for `RecordParameterPropertyDescriptor`. This will allow nested record to be properly harvested for their properties.
e912598 to
2315a72
Compare
Contributor
Author
|
Fixed formatting |
Member
|
Thanks. I think it's an oversight that we didn't add support for this in 3.3 when we added record metadata support. |
mhalbritter
pushed a commit
that referenced
this pull request
Jul 4, 2024
Add ElementType.RECORD_COMPONENT to NestedConfigurationProperty and implement isMarkedAsNested for RecordParameterPropertyDescriptor. This will allow nested records to be properly harvested for their properties. See gh-41251
Contributor
|
Thanks very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ElementType.RECORD_COMPONENTtoNestedConfigurationPropertyand implementisMarkedAsNestedforRecordParameterPropertyDescriptor.This will allow nested record to be properly harvested for their properties.
I've added a test case which fails to retrieve nested record groups property using the
@NestedConfigurationPropertyannotation.This change adds the support for nested record to be properly extracted into groups when using
@NestedConfigurationProperty.