Prefer modified resources over the originals in TestCompiler#33850
Closed
wilkinsona wants to merge 1 commit into
Closed
Prefer modified resources over the originals in TestCompiler#33850wilkinsona wants to merge 1 commit into
wilkinsona wants to merge 1 commit into
Conversation
Previously, when the test compiler had been seeded with a resource file, any modifications to this resource performed during compilation would be lost as this original content would always be returned. This commit updates the DynamicJavaFileManager to always store the dynamic resource in the dynamicResourceFiles map, irrespective of whether it's being created afresh or from some existing resource content. This ensures that any modifications made to the resource can be retrieved later on. Similarly, DynamicClassLoader has been updated to prefer dynamic resource files over any original resource files. This ensures that the resource that it finds reflects any modifications that have been made to it.
TestCompiler
TestCompiler
snicoll
pushed a commit
that referenced
this pull request
Nov 6, 2024
Previously, when the test compiler had been seeded with a resource file, any modifications to this resource performed during compilation would be lost as this original content would always be returned. This commit updates the DynamicJavaFileManager to always store the dynamic resource in the dynamicResourceFiles map, irrespective of whether it's being created afresh or from some existing resource content. This ensures that any modifications made to the resource can be retrieved later on. Similarly, DynamicClassLoader has been updated to prefer dynamic resource files over any original resource files. This ensures that the resource that it finds reflects any modifications that have been made to it. See gh-33850
snicoll
added a commit
that referenced
this pull request
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when the test compiler had been seeded with a resource file, any modifications to this resource performed during compilation would be lost as the original content would always be returned.
This PR updates the
DynamicJavaFileManagerto always store the dynamic resource in thedynamicResourceFilesmap, irrespective of whether it's being created afresh or from some existing resource content. This ensures that any modifications made to the resource can be retrieved later on.Similarly,
DynamicClassLoaderhas been updated to prefer dynamic resource files over any original resource files. This ensures that the resource that it finds reflects any modifications that have been made to it.